Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for form_urlencoded::parse #130

Merged
merged 1 commit into from Sep 16, 2015
Merged

Adds docs for form_urlencoded::parse #130

merged 1 commit into from Sep 16, 2015

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Sep 16, 2015

Hello,

I found myself wondering if this function would actually decode the values, as opposed to just splitting on the = sign and making some validity checks. I would be nice to have docs just say that the names/values are decoded.

Best regards,
Conrad

Review on Reviewable

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Sep 16, 2015

That’s a good point, thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Sep 16, 2015

📌 Commit 1524703 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Sep 16, 2015

Testing commit 1524703 with merge 6f90be3...

bors-servo pushed a commit that referenced this issue Sep 16, 2015
Adds docs for form_urlencoded::parse

Hello,

I found myself wondering if this function would actually decode the values, as opposed to just splitting on the `=` sign and making some validity checks. I would be nice to have docs just say that the names/values are decoded.

Best regards,
Conrad

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/130)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Sep 16, 2015

☀️ Test successful - travis

@bors-servo bors-servo merged commit 1524703 into servo:master Sep 16, 2015
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants